Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing tests for xlsb #905

Open
JanMarvin opened this issue Jan 20, 2024 · 1 comment
Open

missing tests for xlsb #905

JanMarvin opened this issue Jan 20, 2024 · 1 comment
Labels
help wanted 🙏 Extra attention is needed

Comments

@JanMarvin
Copy link
Owner

Total coverage is severely impacted by missing xlsb tests. Improving coverage can be tricky, because some tests will fail on big endian systems, maybe we need some way to skip these on big endian systems.

Create a more complex test file with everything possible and unsupported features as well

  • Working features
  • Not working features
  • more complex formulas
  • external references
  • data validation
  • dxfs styles
@JanMarvin JanMarvin added the help wanted 🙏 Extra attention is needed label Jan 20, 2024
@JanMarvin JanMarvin reopened this Apr 25, 2024
@JanMarvin
Copy link
Owner Author

Accidentally closed.

Apparently we do not handle future functions yet. Below a zip file containing an xlsx and an xlsb file using SEQUENCE(5). In the xlsb file we read:

wb$workbook$definedNames
#> [1] "<definedName name=\"_xlfn.SEQUENCE\" hidden=\"1\">#NAME?</definedName>"
wb$worksheets[[1]]$sheet_data$cc$f[1]
#> [1] "User_Defined_Function(1,5)"

This should be converted to:

wb$worksheets[[1]]$sheet_data$cc$f[1]
#> [1] "_xlfn.SEQUENCE(5)"

Archive.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted 🙏 Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant