Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanks Jan, great work! Small keybinding issue. #1

Open
Arcitec opened this issue Nov 26, 2019 · 0 comments
Open

Thanks Jan, great work! Small keybinding issue. #1

Arcitec opened this issue Nov 26, 2019 · 0 comments

Comments

@Arcitec
Copy link

Arcitec commented Nov 26, 2019

Thanks a lot for creating this extension and sharing it with the world. There were tons of themes switchers on the marketplace but most were focused on switching between two themes, which is way too restrictive. I prefer cycling between a few nice themes based on mood.

The other extensions only handled two themes and were based on "time of day" or "night mode" and other stuff which I have no control over, so they weren't really suitable. Yours is nice and the code is clean and simple and just lets you cycle manually. Perfect.

I noticed two small issues with the keybindings:

  1. The docs list the wrong keybindings (one of the entries is duplicated, for example).
  2. Ctrl+Shift+F12 is problematic. It conflicts with and therefore overwrites "Peek Implementation", which is a really cool keybind that lets you view a floating overlay that shows the code definition of the function the cursor is at. I noticed that another theme (Sundial) had a really good idea for theme switching key: Ctrl+Alt+T. It is not bound to anything in VSCode and is pretty easy to hit. So my suggestion would be to not bind any keys by default (in the extension) except for "Next Theme (from separate list in settings)", bound to Ctrl+Alt+T. That way there's a single key to loop through themes from the user-made list, and the user can manually bind more hotkeys if they want the other features this addon provides. What do you think?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant