Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications may not fit the mobile screen #1645

Closed
Yngwarr opened this issue May 3, 2018 · 8 comments
Closed

Notifications may not fit the mobile screen #1645

Yngwarr opened this issue May 3, 2018 · 8 comments
Labels
to be closed Resolved or outstanding issues that are obsolete or no longer necessary

Comments

@Yngwarr
Copy link

Yngwarr commented May 3, 2018

Screenshot

That's what I'm talking about.

@local-minimum
Copy link
Contributor

Yes, this is known. Someone with more CSS skills than me need to look into that.

@Yngwarr
Copy link
Author

Yngwarr commented May 3, 2018

Huh! Actually, I can do it. =)

@crs38c28
Copy link

crs38c28 commented May 4, 2018

It's in here

	& .-items {
		width: 480px;
		max-width: 480px !important;
		right: 0px;
		top: 55px;
		background: @COL_W !important;

change width can solve this problem.

size

maybe use width: calc(100vw - 2em - 48px); can fix this?

But it seems like calc() in LESS ( < 3.0) is different...

=> [more information] , [more information]

@mikekasprzak mikekasprzak added the bug Unintended behavior label May 11, 2018
@mikekasprzak mikekasprzak added this to the End of 2018 milestone May 26, 2018
@Josh6680
Copy link

Josh6680 commented Jun 3, 2018

I had a different approach to this where the position becomes "relative" to the top-right corner below the top bar, and 100% wide for screens that are smaller than the max-width.

--- a/src/com/view/bar/bar-notifications.less
+++ b/src/com/view/bar/bar-notifications.less

        margin: 0px !important;

        & .-items {
-               width: 480px;
+               width: 100%;
                max-width: 480px !important;
                right: 0px;
-               top: 55px;
+               top: 64px;
                background: @COL_W !important;
+               position: fixed;

                & .-item {
                        padding: 0px !important;

Here's a GIF of this while resizing the screen using Firefox devtools:
https://user-images.githubusercontent.com/1106285/40889543-6158b3ba-6736-11e8-8070-c43b494d29a1.gif

@local-minimum
Copy link
Contributor

I'm fine with either just as long as we get one in.

@mikekasprzak
Copy link
Member

Opened a new issues (#1684) for the lesscss upgrade. There was a bug in lesscss that was holding us back, but it might be fixed now.

@mikekasprzak mikekasprzak added the to be closed Resolved or outstanding issues that are obsolete or no longer necessary label Jun 6, 2018
@mikekasprzak
Copy link
Member

I'm re-opening the issue (even though it's resolved) for later when future me gets a chance to look at the notes above. We have a long list of mobile screen fitting issues, and I want to understand some of the proposed fixes if they can be used to resolve some of the other related issues.

@mikekasprzak mikekasprzak reopened this Jun 6, 2018
@mikekasprzak mikekasprzak modified the milestones: End of 2018, !Next LD (August 2018) Jun 6, 2018
@local-minimum local-minimum added enhancement and removed bug Unintended behavior labels Jun 7, 2018
@local-minimum
Copy link
Contributor

changed tags so it is clear that this isn't as important anymore.

@mikekasprzak mikekasprzak removed this from the End of 2018 milestone Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to be closed Resolved or outstanding issues that are obsolete or no longer necessary
Projects
Development

No branches or pull requests

5 participants