Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Variant type from as-variant #64

Open
mattjohnsonpint opened this issue Mar 27, 2024 · 1 comment
Open

Support Variant type from as-variant #64

mattjohnsonpint opened this issue Mar 27, 2024 · 1 comment

Comments

@mattjohnsonpint
Copy link
Contributor

mattjohnsonpint commented Mar 27, 2024

The as-variant library is a dependency:

as-json/package.json

Lines 46 to 50 in 4915854

"dependencies": {
"as-string-sink": "^0.5.3",
"as-variant": "^0.4.1",
"as-virtual": "^0.1.9"
},

But it's not used in any code. An attempt to serialize a variant:

const v = Variant.from(123);
const s = JSON.stringify(v);

fails with: Could not serialize data of type Variant. Make sure to add the correct decorators to classes.

Which of course, we can't do because it's an external library.

@JairusSW - Given your comment in #49 (comment), can you please look in to adding support for variants so they work?

Thanks.

@JairusSW
Copy link
Owner

Yeah, that'll be coming in the next big release.
I'll start pushing out my local changes to the devlop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants