Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on gulp #153

Open
eseliger opened this issue Jun 27, 2018 · 2 comments
Open

Remove dependency on gulp #153

eseliger opened this issue Jun 27, 2018 · 2 comments

Comments

@eseliger
Copy link

As per gulp plugin guidelines, there should be no dependency on gulp itself, for a good reason. So removing it as a dependency and adding it as a devDependency should be viable in my opinion. I can open a PR with this if you agree

@JemiloII
Copy link

@eseliger gulp should be a peer dependency as the package requires it, however, as a peer dependency, we can update the module with our own security updates as needed.

@eseliger
Copy link
Author

If I get your point correctly, you are worried about using the wrong version of gulp with this plugin? If not, please correct me.
If that is what you are saying, you can always define a range of valid gulp versions compatible with gulp-nodemon
So you can still ensure gulp being the version you want it to be 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants