Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display attached files in refererenced crossref entry #7731

Open
ilippert opened this issue May 12, 2021 · 18 comments · Fixed by Toro520/jabref#1 · May be fixed by #9717
Open

Display attached files in refererenced crossref entry #7731

ilippert opened this issue May 12, 2021 · 18 comments · Fixed by Toro520/jabref#1 · May be fixed by #9717

Comments

@ilippert
Copy link

I have an entry A, say an edited volume, and have linked to it a file AF.

Entry B crossreferences A.

The entry table successfully uses some data of A to present data for B.
I am frustrated because the link to AF is not shown for B in the entry table.

Proposal. IFF B does not have own files attached, offer AF in the entry table.

@Siedlerchr Siedlerchr changed the title Crossref to also crossref file Display attached files in refererences crossref entry May 14, 2021
@Siedlerchr Siedlerchr changed the title Display attached files in refererences crossref entry Display attached files in refererenced crossref entry May 14, 2021
@Siedlerchr Siedlerchr added this to Normal priority in Features & Enhancements via automation May 14, 2021
@koppor koppor added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Jul 13, 2021
@calixtus
Copy link
Member

Maybe a bindings problem with the reference to the crossrefd bibentry...?

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Sponsor Member

k3KAW8Pnf7mkmdSMPHz27 commented Jul 20, 2021

It is possibly solved if #7730 is fixed (as long as we are talking about the entry-editor and not the maintable). It should be mitigated by #7754. I am not sure if all the buttons/menus will work as expected for files after #7730 / #7754.

@calixtus
Copy link
Member

calixtus commented Jul 21, 2021

Monday I got word that maybe some students from a computer science course are looking into this issue the next days.

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Sponsor Member

k3KAW8Pnf7mkmdSMPHz27 commented Jul 21, 2021

Ok. I don't know what the simplest solution is in that case.

I haven't seen any new PR/commits from @SuXiChangZhen so I am assuming it is ok that I finish the currently open PR and someone else can continue with a complete solution (or a complete solution only for the file field).
I think the last of the suggestions in #7754 (comment) is the most likely to work but I am not sure if that is a "good first issue" anymore, but it still might be if only implemented for the file field.

I can expand on the comments there, as long as it is before Friday. I am going to be away for 10 days and I am not sure if I'll have cellphone coverage.

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Sponsor Member

Ok, turns out that I was wrong. #7754 has probably nothing to do with this one since it only is relevant for the main table, not the entry editor. Terribly sorry for the confusion!

@RhodevdDool
Copy link

Hi, is anyone currently working on this? If not, I'd like to give it a try.
Apart from the devdocs and the above information, is there anything specific I should know about this?

@calixtus
Copy link
Member

calixtus commented Aug 2, 2021

Hi @RhodevdDool, thank you for your interest in JabRef programming. We always appreciate if people want to contribute. About this issue: Currently there is a student group from china (?) working on this. Their teacher told me, that they should be done on the 8. of august. If there is no PR then present, this issue should be available again.

@RhodevdDool
Copy link

@calixtus Thank you! I used JabRef for my thesis, and am excited to maybe contribute in turn. I'll check it out in a week.

@calixtus
Copy link
Member

calixtus commented Aug 2, 2021

😍 This is exactly how most of us started with JabRef programming! Either as a distraction from the thesis or - just like you - after we were done. But don't forget: Working on JabRef should be fun!

@ilippert
Copy link
Author

dear community,
just asking for clarification - is anybody of you still working on this? It would be so great to see progress on this issue.

@HighCrit
Copy link

If no one else is working on this. Could I be assigned to this issue? I wish to work on it as part of a uni course.

@ThiloteE ThiloteE added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Mar 16, 2023
@github-actions
Copy link
Contributor

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

@HighCrit HighCrit removed their assignment Oct 14, 2023
@Toro520
Copy link

Toro520 commented Oct 22, 2023

Hi there,
I'm new here. I'm interested about it and wanna combined with my knowledge and practice together to solve it. Could I be able to assigned to this issue and have a try? Thanks again.

@ThiloteE
Copy link
Member

@Toro520 Sure, go ahead, looks like HighCrit abandoned the project.
@HighCrit Thank you for unassigning yourself.

@koppor
Copy link
Member

koppor commented Oct 23, 2023

This issue somehow refs #8128 - even though this issue is talking about a single file and "virtually" presenting it at another place; whereas #8128 also talks about a single file, but different positions in that file (which is currently unclear how to configure).

@Toro520
Copy link

Toro520 commented Oct 24, 2023

Hey there,
This is really an awesome application. Had a glance of the code, the skeleton is really complex. I'm considering this issue #7731, so if I wanna fix it, where could I start it, and which package and class should I to edit and have a improve? Thanks guys.

@ThiloteE
Copy link
Member

@Toro520 have a look at #9717. HighCrit already contributed some code, so maybe you can continue from there.

image

@Toro520
Copy link

Toro520 commented Oct 24, 2023

@ThiloteE Thank you so much. :)

@ThiloteE ThiloteE mentioned this issue Oct 30, 2023
6 tasks
@calixtus calixtus removed good first issue An issue intended for project-newcomers. Varies in difficulty. FirstTimeCodeContribution Triggers GitHub Greeter Workflow labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment