We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We need to update the CSS definitions to use em instead of px, because em adapts with the font size.
em
px
An em is a unit of measurement, relative to the size of the font; therefore, in a typeface set at a font-size of 16px, one em is 16px.
Update all pixel definitions (px) to em. This is not an easy task, because the em value depends on the font size, but the px size is a hard coded one.
Base.css
This takes a long time, because there are over 20 such values.
Please take screenshots before and after to ease reviewing.
Background material: https://openjfx.io/javadoc/22/javafx.graphics/javafx/scene/doc-files/cssref.html (linked from https://devdocs.jabref.org/code-howtos/javafx.html#resources, too)
All .css definitions are spread around in the code base. We need to have them all in one Base.css to be able to work on some CSS issues.
Migrate all CSS files to the Base.css. For instance: https://github.com/JabRef/jabref/blob/main/src/main/java/org/jabref/gui/texparser/ParseLatexResult.css
Do not touch Dark.css. It needs to be kept for dark mode support. It does not contain any px values, because it does color only.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
We need to update the CSS definitions to use
em
instead ofpx
, becauseem
adapts with the font size.Update all pixel definitions (
px
) toem
. This is not an easy task, because theem
value depends on the font size, but the px size is a hard coded one.px
entry inBase.css
This takes a long time, because there are over 20 such values.
Please take screenshots before and after to ease reviewing.
Background material: https://openjfx.io/javadoc/22/javafx.graphics/javafx/scene/doc-files/cssref.html (linked from https://devdocs.jabref.org/code-howtos/javafx.html#resources, too)
Preparation
All .css definitions are spread around in the code base. We need to have them all in one
Base.css
to be able to work on some CSS issues.Migrate all CSS files to the Base.css. For instance: https://github.com/JabRef/jabref/blob/main/src/main/java/org/jabref/gui/texparser/ParseLatexResult.css
Notes
Do not touch Dark.css. It needs to be kept for dark mode support. It does not contain any
px
values, because it does color only.The text was updated successfully, but these errors were encountered: