Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding keywords for new entries only possible when clicking on the top left corner of the field #11177

Open
1 of 2 tasks
teertinker opened this issue Apr 10, 2024 · 11 comments
Open
1 of 2 tasks
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor ui

Comments

@teertinker
Copy link
Contributor

teertinker commented Apr 10, 2024

JabRef version

5.13 (latest release)

Operating system

GNU / Linux

Details on version and operating system

No response

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

JabRef 5.13--2024-04-01--6bdcf63
Linux 6.5.0-26-generic amd64
Java 21.0.2
JavaFX 22+30

  1. Import or create a new entry without keywords
  2. Try to enter a keyword
  3. nothing happens

In contrast for entries with preexisting Keywords, I can add a new keyword without problems.

[May be of relevance: I have a wordlist saved for keywords (selector_keywords)]

My current workaround: Enter a new line for keywords directly in the bibtex of the entry with one new keyword.

Appendix

...

Log File
Paste an excerpt of your log file here
@teertinker teertinker changed the title Cannot add keywords Cannot add keywords for new entries without preexisting keywords Apr 10, 2024
@Siedlerchr
Copy link
Member

Yeah it's kind of disabled until you enter something in another field

@Siedlerchr Siedlerchr added the bug Confirmed bugs or reports that are very likely to be bugs label Apr 10, 2024
@teertinker
Copy link
Contributor Author

Thank you for your helpful comment. I realised that the behavior is the same for other fields. For example "crossref" also seems to be locked until i enter something in another field.

Hopefully this helps to narrow down the source of the problem.

@Siedlerchr Siedlerchr added the ui label Apr 10, 2024
@koppor
Copy link
Member

koppor commented Apr 10, 2024

@LoayGhreeb maybe you can have a look?

@koppor koppor added this to the 5.14 milestone Apr 10, 2024
@LoayGhreeb
Copy link
Collaborator

maybe you can have a look?

I can't reproduce the issue I tested it on windows 11.

  1. create a new library
  2. add a new entry
  3. add a keyword, and it works as expected
  4. also tried with and without the content selectors, and with and without auto-completion
preview.mp4

@teertinker
Copy link
Contributor Author

Hi there,
I have been testing 5.13 on my Windows machine and have been able to narrow down the issue. It seems that this is not a real bug as it first appeared.
It seems to be a "user error": I can only fill in the keywords field if I click on the very first line of the field. By accident, I have sometimes clicked somewhere in the keywords field (as it is multiline) and thought the field was locked. This happens on both my Linux and Windows machines. Also, unlike other fields, the keywords field (and crossref) does not get a coloured frame when it is activated.
This does not seem to be a real bug, but it may irritate other users.

The same behaviour can be seen in the crossref field.

@LoayGhreeb
Copy link
Collaborator

LoayGhreeb commented Apr 10, 2024

Refs #10910 (comment), #10910 (comment)

@Siedlerchr
Copy link
Member

Yeah, this still feels weird. By contrast, if I click on the comment field somewhere in the middle, the first line will be focused
Maybe we can report it upstream to the gemsfx repo

@koppor koppor added the status: depends-on-external A bug or issue that depends on an update of an external library label Apr 10, 2024
@calixtus
Copy link
Member

I will take a look. Im not sure if this is about gemsfx but our buggy entry editor. I believe the inner control does not fit the size of the outer field editor border. I believe we had the issue discussed before. I will look into it.

@LoayGhreeb
Copy link
Collaborator

I think yes, maybe it's not related to GemsFx, because when I tried what you suggested in #10910 (comment) it works fine, but there was an issue with binding. Will give it a try.

@LoayGhreeb
Copy link
Collaborator

LoayGhreeb commented Apr 11, 2024

I tried the GemsFx demo and can confirm that the issue is not related to them.
Here is how it looks in their demo:

image

@koppor koppor removed the status: depends-on-external A bug or issue that depends on an update of an external library label Apr 11, 2024
@ryan-carpenter
Copy link

ryan-carpenter commented May 2, 2024

Yeah it's kind of disabled until you enter something in another field

Pressing Tab or Shift + Tab allows me to move ahead or back to the 'disabled' Keywords field. I need to enter the other field first, as you mentioned, but do not need to enter data in the other field to 'enable' Keywords. It's great that you have enhanced the keyword functionality. 🥇

Edit: @teertinker is right.

I can only fill in the keywords field if I click on the very first line of the field

To clarify, it is necessary to click at the beginning of the line (beginning of the field, not just anywhere on the first line).

@koppor koppor removed this from the 5.14 milestone May 20, 2024
@koppor koppor changed the title Cannot add keywords for new entries without preexisting keywords Adding keywords for new entries only possible when clicking on the top left corner of the field May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor ui
Projects
Status: Normal priority
Development

No branches or pull requests

6 participants