New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When creating an entry based on a PDF, the file path should be relative #11173
Comments
Hi Oliver, Thanks for your reply on the mail. We are a group of 6 students from University of Adelaide, we would like to pursue this issue. Can you please assign this to me. Thanks, |
As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at. Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback. |
Hi Oliver, Thanks for the insight, although we will split the work between the team. We have to create report, presentations, test cases and prepare for demos in the course as well. We would surely be taking more issues if we are able to finish this off in time. Appreciate your insights and I'll get back to you as soon as possible with updates. |
Are you still pursuing this issue? |
On my machine with some custom configurations (which should be irrelevant here), using JabRef's development version (Windows 10), a relative file path looks like this, which differs from yours: I see that you have |
I believe this is a different issue from the one reported, we are working on the issue reported by Oliver, where the file path in the BibTex source is not relative. As per the fix that I have in my local, it is now storing the expected relative path in the BibTex Source. @koppor please let me know if my understanding is correct. |
On a second thought, @ThiloteE I believe the preferences that you have appears to be different from the one Oliver has provided. The ImportHandler class that we are working on for the issue reported by Oliver, does not seem to be handling the regular expressions in the preferences, it could be a different logic to handle the regex expressions in the preferences. |
@Arshadpd I see that the file path is relative.
|
Hi @koppor , Thanks for the pointers,
|
By the way, thank you for your efforts and motivation to work on this. Yes, my preferences are different from what Oliver provided, but it is still something that JabRef supports. If you provide a pull-request with the code, I can do some simple tests myself, such as moving my .bib library to a new location and importing it. Or you copy my preferences and do the tests on your fork, then you can rule out any syntax differences that stem from enabling "linked file name conventions". My intention is simply to check for breaking changes. The link to the video you provided does not work 🙅 |
Hi @ThiloteE , Sorry for the inconveniences, I'll add the video to my drive and share the link here. I'll be creating a pull request as soon as possible. Thanks for all the support. |
https://drive.google.com/file/d/1wG71ME3lfLlR_YcsrRy815onngvlgoyG/view?usp=sharing Thanks Oliver, I've already screen recorded the functionality in local. Please let me know if the above link is accessible and the thoughts on the video. |
@Arshadpd I see it. Now I am curious to the code. |
When an entry is created using a PDF (by drag'n'drop on the main table - either at the free space or between two lines), the path of the linked PDF is stored as absolute path, but not relative. This needs to be fixed.
Implementation hint: There is functionality inside JabRef to make a path relative. It "just" needs to be found and wired correctly into that drop handling
Pre condition
Setting that files are stored relative to library file location.
Details
Example PDF: IST2015.pdf
Created BibTeX:
See that the content of
file
has an absolute path. That should be relative.Follow-up issue
The newly created entry is not added to the currently selected group. When working on this, please also try to fix this.
Other places where drag'n'drop works correctly
The text was updated successfully, but these errors were encountered: