Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] COM and NAV volumes cannot be set with keyboard input #50

Open
thestonefox opened this issue Dec 14, 2020 · 11 comments
Open

[BUG] COM and NAV volumes cannot be set with keyboard input #50

thestonefox opened this issue Dec 14, 2020 · 11 comments

Comments

@thestonefox
Copy link

Current version:

  • Current mod version: V0.9.3
  • Current MSFS version: 1-11-7-0-hot-fix

Describe the bug
Trying to set a key to increase/decrease the COM or NAV volume doesn't work. When you press the increase or decrease key, it moves the knob in the sim but when you release they key then the knob returns to the last value set by the mouse clicking on the volume control in the cockpit.

To Reproduce
Steps to reproduce the behaviour:

  1. Set a key to increase/decrease COM1 volume
  2. In the cockpit, press and hold the key to increase (or decrease) the COM1 volume
  3. Watch the volume knob rotate, release the key
  4. Watch the volume knob automatically rotate back to the original set position

Expected behaviour
I expect the volume knob not to reset back when I release the key

Screenshots
knobbug

Additional context
Tested in the base sim without the mod and the volume keys work as expected

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.98. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the bug Something isn't working label Dec 14, 2020
@github-actions github-actions bot added this to Investigating in V1.0.0 Roadmap Dec 14, 2020
@N95JPL
Copy link
Member

N95JPL commented Dec 15, 2020

Thanks for the report!
I hadn't tried to with keybinds!

I will get this corrected!

@thestonefox
Copy link
Author

thanks very much :) I only noticed it when I was setting up my streamdeck and wanted to send a keybind press

@jeffdamp-wave
Copy link

I'm seeing the same issue with the ComNav Audio panel. I posted this in the MSFS forum but will post here too:
I’m using mobiflight+FSUIPC and find that with your mod a number of the controls will get reset after they are set with mobiflight.
Items I’ve found so far
Radio Volume Knobs (all)
NavCom Sound panel all buttons
Example:
I send in:
783938 *** EVENT: Cntrl= 66465 (0x000103a1), Param= 0 (0x00000000) COM_RECEIVE_ALL_TOGGLE
And then this event is fired right after resetting my setting:
784063 *** EVENT: Cntrl= 66466 (0x000103a2), Param= 0 (0x00000000) COM_RECEIVE_ALL_SET

@N95JPL
Copy link
Member

N95JPL commented Jul 18, 2021

I'm investigating this as SU5 has changed how all these work!
They are set currently to basically act as default and it doesn't appear to be working for me either!

Can you send me an example of how you're setting up MobiFlight? I've never used it before so not sure I'm doing it right!

@N95JPL
Copy link
Member

N95JPL commented Jul 18, 2021

Okay, I have found the issue with the resetting values!

Sorting out the fix for it now, unfortunately I'm unable to get MobiFlight working... maybe I'm being stupid...

I've been testing on the BOTH switch, using key binding now works!

@jeffdamp-wave
Copy link

If you get it to work on KB/joystick I can get it to work in MobiFlight. Mobiflight can simulate KB or Joystick (via VJoy). It also uses the under lying event system to send events to MSFS in a few different ways. Let me know if you want me to test out a change.

@N95JPL
Copy link
Member

N95JPL commented Jul 18, 2021

Perfect!
I'd offer you to test out the V1.0.0 beta, however I can only do that if you are part of the PerformancePLUS Beta?
If not, I will do what I can before the V1.0.0 release, then once that's public if you could please test again?
I will then issue any fixes via anyone update/beta phase!
Thanks!

@jeffdamp-wave
Copy link

I'm not in the PerfomancePLUS Beta but "I know a guy" :) so I'll see about getting into it.

@N95JPL
Copy link
Member

N95JPL commented Jul 18, 2021

Perfect!
Let me know if you manage to get on!

Quick Q: Can use set LVar values through MobiFlight?

@N95JPL N95JPL moved this from To do to In progress in V1.0.0 Release Jul 21, 2021
@N95JPL
Copy link
Member

N95JPL commented Jul 21, 2021

This is in progress, the knobs don't reset now when changed via the volume key... although I am still fighting an issue

When starting dark & cold, turning the radios on initially via the key keeps the circuits switched off... use mouse and drag, circuits come alive, the keys work normally then

I'll continue checking it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
V1.0.0 Release
In progress
Development

No branches or pull requests

3 participants