Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModifyOrderByClientOrderIdAsync should take a string for clientOrderId #31

Open
kevindarby opened this issue Aug 10, 2022 · 0 comments
Open

Comments

@kevindarby
Copy link

Describe the bug
I believe the IFTXClientTradeApiTrading.ModifyOrderByClientOrderIdAsync interface and impl should take a string for clientOrderId (the first argument)

To Reproduce
See here:

Task<WebCallResult<FTXOrder>> ModifyOrderByClientOrderIdAsync(long clientOrderId, decimal? price = null, decimal? quantity = null, string? newClientOrderId = null, string? subaccountName = null, CancellationToken ct = default);

clientOrderId is declared as a long

Expected behavior
clientOrderId is a string in the cancel and place methods, so it should probably be a string here.

kevindarby added a commit to lurium/FTX.Net that referenced this issue Aug 12, 2022
ModifyOrderByClientOrderIdAsync should take a string clientOrderId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant