Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airdrops API status field invalid conversion #20

Open
OlegOLK opened this issue Jan 23, 2022 · 1 comment
Open

Airdrops API status field invalid conversion #20

OlegOLK opened this issue Jan 23, 2022 · 1 comment

Comments

@OlegOLK
Copy link

OlegOLK commented Jan 23, 2022

When using FTXClient.GetAirdropsAsync method according to the official FTX documentation you get in the return response object that contains status property (https://docs.ftx.com/#get-airdrops). Unfortunately on the left side of the documentation, there are two possible values:
one of "confirmed" or "pending"
But the thing is on the right side you can clearly see that the status value is "complete".
This invalid mapping results in the "pending" status for every single airdrop entity even if it has the status "complete".

To reproduce you need to have an account with some airdrops on it and then

var client = new FTXClient(new FTXClientOptions(){
HttpClient = _client,
ApiCredentials = new ApiCredentials(wallet.ApiKey, wallet.ApiSecret),
LogLevel = LogLevel.Debug,
LogWriters = new List<ILogger> { _logger } });
var airdrops = await client.GetAirdropsAsync(startTime: chunk.from, endTime: chunk.to).ConfigureAwait(false);
airdrops.Data.All(x=> x.Status == AirdropStatus.Pending).Should().BeTrue();

Expected to have

airdrops.Data.All(x=> x.Status == AirdropStatus.Pending).Should().BeFalse(); // and be "complete"

@OlegOLK
Copy link
Author

OlegOLK commented Jan 23, 2022

Fix for that issue: https://github.com/OlegOLK/FTX.Net/tree/fix-airdrop-status-mapping
The only thing with that fix is ideally naming for AirdropStatus.Confirmed should be changed to AirdropStatus.complete but this will result in breaking change. So I can prepare two branches:

  1. first with updating only string property value for correct mapping
  2. second branch with the renaming of all dependent code. But it should be released I think with an increased major version of the package.

@JKorf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant