Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Privacy Manifest #750

Open
hkellaway opened this issue Mar 19, 2024 · 6 comments · Fixed by #753 or #758
Open

Add Privacy Manifest #750

hkellaway opened this issue Mar 19, 2024 · 6 comments · Fixed by #753 or #758

Comments

@hkellaway
Copy link

Hello -

I'm wondering what plans there are to add a Privacy Manifest? Thanks!

https://developer.apple.com/support/third-party-SDK-requirements/
https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api

@djs-code
Copy link

+1. The App Store will be enforcing this more strictly starting on May 1st.

@Ayyanchira Ayyanchira linked a pull request Mar 22, 2024 that will close this issue
@Ayyanchira
Copy link
Member

Thank you for your patience @hkellaway and @djs-code .
Next release will have privacy manifest included :)

@evantk91
Copy link
Contributor

6.5.1 has been released with the privacy manifest

@djs-code
Copy link

djs-code commented Apr 2, 2024

@Ayyanchira @evantk91 I don't believe this is truly complete yet; if my understanding is correct, you will also need to add the following to the IterableSDK target in your Package.swift:

resources: [.process("PrivacyInfo.xcprivacy")]

@Ayyanchira
Copy link
Member

Thanks for informing this @djs-code.
Somehow adding resources: [.process("PrivacyInfo.xcprivacy")] in SDK's Package.swift still isn't including SDK's Privacy Labels in generated Privacy report.
Will update here once I find a solution.

@Ayyanchira Ayyanchira reopened this Apr 2, 2024
@Ayyanchira Ayyanchira linked a pull request Apr 5, 2024 that will close this issue
@einsteinx2
Copy link

Using the latest 6.5.2 release I can confirm that the privacy manifest is now included when using SPM, but not with Cocoapods.

I think you need to update this line to also match the privacy manifest file:

s.resource_bundles = {'Resources' => 'swift-sdk/Resources/**/*.{storyboard,xib,xcassets,xcdatamodeld}' }

Probably something like the following since you've already moved it to your resources folder according to your release notes:

s.resource_bundles = {'Resources' => 'swift-sdk/Resources/**/*.{storyboard,xib,xcassets,xcdatamodeld,xcprivacy}' }

Or alternatively you could probably specify a second dedicated resource bundle in that dictionary called something like 'Resources-Privacy' and specifically include the manifest file. You can confirm by adding it to a test project with Cocoapods and generating a privacy report after archiving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants