Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate computing and populating the rewards at the epoch boundary #1693

Open
kderme opened this issue May 7, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@kderme
Copy link
Contributor

kderme commented May 7, 2024

The ledger incrementaly computes the rewards and make them available through the Reward event. DBSync extracts these events and stores them (one small batch per block) in the db. It may make sence to force the whole computation similarly to what we do for the drep incremental calculation.

Pros:

  • rewards will be available earlier, ie the moment that the incremental computation is prepared instead of when it's finished.
  • syncing speed may be improved. This is because the incremental computation may have many small queries. When we force the whole computation, we can have less queries with more entries each time, which is in general faster. To validate this, we should investigate the current size of queries.

Cons:

  • It can cause delays in new epoch boundaries when following the tip, since db-sync will have to suddenly insert a big batch of data. Also something to investigate.
@kderme kderme added the enhancement New feature or request label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant