Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: Preset ALWAYS overrides Ledger #1641

Open
sgillespie opened this issue Mar 4, 2024 · 0 comments
Open

Config: Preset ALWAYS overrides Ledger #1641

sgillespie opened this issue Mar 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@sgillespie
Copy link
Contributor

sgillespie commented Mar 4, 2024

Currently, if using a preset, you cannot also configure the ledger. This is because the preset overrides ALL other options. This means that, in following config,

"insert_options": {
  "preset": "only_utxo",
  "ledger": "enable"
}

The ledger setting will have no effect. We would like to allow users to specify the ledger setting along with the prefix, and set a default if none is specified ("enable").

One way to do this would be to add a Ledger field to all of the preset constructors: https://github.com/IntersectMBO/cardano-db-sync/blob/master/cardano-db-sync/src/Cardano/DbSync/Config/Types.hs#L149

@sgillespie sgillespie added the bug Something isn't working label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant