Make tcencode more performant by avoiding json roundtrip conversion #446
Conversation
patmmccann
changed the title
|
Thank you, a N=1 preliminary test shows this already greatly improves performance, reducing the time to encode the string from 75ms to 15ms. If the cloning of the GVL could be done only once, this would once again halve the time spent, to maybe 8ms. |
| stacks, | ||
| dataCategories, | ||
| vendors: fullVendorList | ||
| }; |
There was a problem hiding this comment.
This is not a deep clone of VendorList, right? We will return references to objects like vendors and anyone outside of the library could update it, maybe it's not good.
The JSON.parse(JSON.stringify()) is ugly and very slow particular for the very big object like GVL. Maybe we can develop an alternative solution creating custom deep clone method in this case as we know the GVL structure?
|
There is PR for GVL clone avoiding |
|
I suggest we close this PR in favor of #447 |
|
I have tested the new clone vs old one and it works 40% faster: |
|
@HeinzBaumann agreed |
fixes #444