Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask to update study if someone's login credentials show a different study from their IA profile #789

Open
SimplyPancake opened this issue Sep 21, 2023 · 2 comments
Labels
back-end These are issues related to our Django back-end enhancement These issues are enhancements to (already existsing) functionality on the website.

Comments

@SimplyPancake
Copy link
Contributor

SimplyPancake commented Sep 21, 2023

Hello! I am not sure if it easy to implement, but I think it should be!
This issue arises from the fact that I am looking to find the amount of master and bachelor students that are a member of Inter-Actief!
I think this could be best implemented by a search filter under More Search options where one can use a cehckbox with the text Is master student or Is bachelor student! I also think that this could be a nice addition to the search filters.


Edited by @Kurocon 2023-10-02 as per comments below:
If someone logs in, we get some information from the UT about their study. If this is different from the study we have on record, we could add a notice to ask the user to update their study in their profile. This notice could simply link them to their profile page to edit it themselves, or to a new page with some info pre-filled or something.

@SimplyPancake SimplyPancake added the feature request For issues that propose an entirely new feature to the website label Sep 21, 2023
@SimplyPancake SimplyPancake changed the title Members filter for master student Members filter for bachelor/master student Sep 21, 2023
@bramvandartel
Copy link
Member

You already can, just select by study. (M-CS, M-BIT)

Furthermore, we are not up-to-date on bachelor/master students, as people don't update their studies a lot.

Might be something to look into, that if someone logs in and we get their study from the UT auth, that we check if the study matches and can then ask 'Are you still studying X?'

@Kurocon
Copy link
Member

Kurocon commented Sep 21, 2023

Might be something to look into, that if someone logs in and we get their study from the UT auth, that we check if the study matches and can then ask 'Are you still studying X?'

This became a bit harder since we now have an intermediary login system, but luckily Keycloak caches this data for us in an attribute so we could request it from the keycloak service (or have it sent along with the login data), and then show a notification banner when someone logs in or views their profile for example. Nice idea

@Kurocon Kurocon added this to Backlog in Inter-Actief/amelie via automation Oct 2, 2023
@Kurocon Kurocon added enhancement These issues are enhancements to (already existsing) functionality on the website. back-end These are issues related to our Django back-end labels Oct 2, 2023
@Kurocon Kurocon changed the title Members filter for bachelor/master student Ask to update study if someone's login credentials show a different study from their IA profile Oct 2, 2023
@Kurocon Kurocon removed the feature request For issues that propose an entirely new feature to the website label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end These are issues related to our Django back-end enhancement These issues are enhancements to (already existsing) functionality on the website.
Projects
Development

No branches or pull requests

3 participants