Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freshly create plot schematic is regenerated (cleared) one block too low #4404

Open
2 tasks done
PierreSchwang opened this issue Apr 19, 2024 · 0 comments
Open
2 tasks done
Labels
Bug Something isn't working

Comments

@PierreSchwang
Copy link
Member

Server Implementation

Paper

Server Version

1.20.4

Describe the bug

When clearing a plot in an area utilizing plot schematics, the schematic will be pasted one block too low.
World-Generation itself works (e.g. //regen works).

The culprit seems to be somewhere here (used by the FAWE Delegate to determine minY for plot schematics):

public int getPlotYStart() {
return SCHEM_Y + plotY;
}

When replacing SCHEM_Y + plotY with getMinBuildHeight() (the same reference point the world generator uses, as visible in HybridGen: https://github.com/IntellectualSites/PlotSquared/blob/main/Core/src/main/java/com/plotsquared/core/generator/HybridGen.java#L76) clear works. My only idea for that being is, that one of these two variables is normalized somewhere - possibly against the road height.
I don't just want to PR my fix, as I'm not sure what the reasoning behind the change was (@dordsor21 ?) and if that does not have any unexpected side effects.

To Reproduce

  1. Create plot schematic as described in wiki (/plot schematic save, move to appropriate schematic folder)
  2. World will be generated accordingly
  3. Claim Plot and run /plot clear
  4. Schematic will be one block too low

Expected behaviour

The schematic should be pasted from the correct y-level

Screenshots / Videos

No response

Error log (if applicable)

No response

Fawe Debugpaste

Fawe Version

Checklist

Anything else?

No response

@PierreSchwang PierreSchwang added the Requires Testing This is a new issue which needs to be approved before labeled with "bug" label Apr 19, 2024
@PierreSchwang PierreSchwang transferred this issue from IntellectualSites/FastAsyncWorldEdit Apr 19, 2024
@PierreSchwang PierreSchwang added Bug Something isn't working and removed Requires Testing This is a new issue which needs to be approved before labeled with "bug" labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant