Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photons shot vs grid size #4

Open
rozos opened this issue Feb 29, 2016 · 0 comments
Open

Photons shot vs grid size #4

rozos opened this issue Feb 29, 2016 · 0 comments

Comments

@rozos
Copy link

rozos commented Feb 29, 2016

I think there is a bug in either sunShine or shootAtAngle functions (PhotonSolver2D.java). Specifically, the number of photons shot in shootAtAngle is not taking into account changes of lx or ly.

For example, if sunAngle is 90 degrees then
in sunShine, spacing = lx/1/rayCount
in shootAtAngle, dx = lx/rayCount and m=rayCount

This means that the number of photons shot is constant. On the other hand, rayPower does not depend on the grid size either. Therefore, the greater the grid size the lower the effect of the same amount of solar power density, which is not reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant