You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As @dzenanz pointed in #20 , the module needs to be refactored. Some classes seem to be specialized versions of classes that exist in the toolkit (Canny detection filters, morphological filters, etc.), but it should be investigated whether better inheritance can be achieved.
Some minor issues related to the refactoring, or which could be done while refactoring are:
As @dzenanz pointed in #20 , the module needs to be refactored. Some classes seem to be specialized versions of classes that exist in the toolkit (Canny detection filters, morphological filters, etc.), but it should be investigated whether better inheritance can be achieved.
Some minor issues related to the refactoring, or which could be done while refactoring are:
Separate the class header from the implementation (e.g. see itk::DescoteauxSheetnessImageFilter).
Provide Set / Get methods using ITK macros for all ivars.
Provide some default values for ivars (e.g. see itk::DescoteauxSheetnessImageFilter).
Provide the implementation for the
PrintSelf
method in cases which is missing or incomplete.Prefer initialization lists over assignment.
The text was updated successfully, but these errors were encountered: