Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the module #22

Open
jhlegarreta opened this issue Oct 11, 2018 · 1 comment
Open

Refactor the module #22

jhlegarreta opened this issue Oct 11, 2018 · 1 comment

Comments

@jhlegarreta
Copy link
Member

jhlegarreta commented Oct 11, 2018

As @dzenanz pointed in #20 , the module needs to be refactored. Some classes seem to be specialized versions of classes that exist in the toolkit (Canny detection filters, morphological filters, etc.), but it should be investigated whether better inheritance can be achieved.

Some minor issues related to the refactoring, or which could be done while refactoring are:

  • Separate the class header from the implementation (e.g. see itk::DescoteauxSheetnessImageFilter).

  • Provide Set / Get methods using ITK macros for all ivars.

  • Provide some default values for ivars (e.g. see itk::DescoteauxSheetnessImageFilter).

  • Provide the implementation for the PrintSelf method in cases which is missing or incomplete.

  • Prefer initialization lists over assignment.

@jhlegarreta
Copy link
Member Author

Hopefully, these two branches, when they eventually get more work and get merged, may help in this tremendous task:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant