Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make instantiation of cost function internal #60

Open
romangrothausmann opened this issue Apr 12, 2019 · 1 comment
Open

Make instantiation of cost function internal #60

romangrothausmann opened this issue Apr 12, 2019 · 1 comment

Comments

@romangrothausmann
Copy link
Member

Why is the (special) cost function (SingleImageCostFunction) not instantiated internally? From the publication it seems that

PathFilterType :: CostFunctionType :: Pointer cost =  
   PathFilterType :: CostFunctionType :: New ();

PathFilterType :: Pointer pathFilter = PathFilterType :: New ();
pathFilter -> SetCostFunction ( cost );

is expected when employing SpeedFunctionToPathFilter.
What cases could there be where the cost function here would not be the predefined SingleImageCostFunction?
If there are no other, the instantiation of cost function could be done internally, so that it is not necessary when using SpeedFunctionToPathFilter.

@thewtex
Copy link
Member

thewtex commented Apr 13, 2019

@romangrothausmann it sounds reasonable to instantiate a reasonable default 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants