Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWIG build warning for itk::ElastixLogLevel #261

Open
tbirdso opened this issue Nov 1, 2023 · 3 comments
Open

SWIG build warning for itk::ElastixLogLevel #261

tbirdso opened this issue Nov 1, 2023 · 3 comments

Comments

@tbirdso
Copy link
Collaborator

tbirdso commented Nov 1, 2023

Observed build warning with ITK v5.4rc2:

itkElastixRegistrationMethod: warning(4): ITK type not wrapped, or currently not known: itk::ElastixLogLevel
itkTransformixFilter: warning(4): ITK type not wrapped, or currently not known: itk::ElastixLogLevel

https://github.com/InsightSoftwareConsortium/ITKElastix/actions/runs/6723314415/job/18273138069

@N-Dekker
Copy link
Collaborator

N-Dekker commented Nov 8, 2023

Thanks for reporting. @tbirdso itk::ElastixLogLevel is a strongly typed enum, defined here:

https://github.com/SuperElastix/elastix/blob/5f0940d2ec5498a6bc98f53c3eaa6a0a1ccd74b3/Core/Main/itkElastixLogLevel.h

SWIG does support strongly typed enumerations:

https://www.swig.org/Doc3.0/CPlusPlus11.html#CPlusPlus11_strongly_typed_enumerations

So it should be fine, I'm not sure how to solve this issue 🤷 Do you have a suggestion?

@dzenanz
Copy link
Member

dzenanz commented Nov 9, 2023

Perhaps take a look at https://github.com/InsightSoftwareConsortium/ITK/blob/master/Documentation/docs/migration_guides/itk_5_migration_guide.md#strongly-typed-enumerations? Concretely, add itk_wrap_simple_class("itk::ElastixLogLevel") to wrapping somewhere.

@tbirdso
Copy link
Collaborator Author

tbirdso commented Nov 9, 2023

@N-Dekker @dzenanz Thanks for the suggestions! This is a low-priority issue that (to my knowledge) is not holding up any work for now. I will not be able to lead a resolution, @dzenanz 's suggestion sounds like the best path forward if someone else would like to take that on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants