From ebedbf71e557fb01e87342dc122fd81c581a12d7 Mon Sep 17 00:00:00 2001 From: Tom Birdsong Date: Wed, 1 Nov 2023 14:29:07 -0400 Subject: [PATCH] ENH: Test notebooks with ITK reusable workflow Replace ITKElastix notebook test workflow with general notebook test workflow from ITKRemoteModuleBuildTestPackageAction. Under previous behavior ITKElastix notebook tests relied on the latest published release and were not reflective of fixes in individual PRs. The updated workflow uses the latest wheel build artifact in notebook tests to immediately reflect proposed changes. --- .github/workflows/build-test-package.yml | 2 ++ .github/workflows/notebook-test.yml | 25 ------------------------ 2 files changed, 2 insertions(+), 25 deletions(-) delete mode 100644 .github/workflows/notebook-test.yml diff --git a/.github/workflows/build-test-package.yml b/.github/workflows/build-test-package.yml index 2c91c944..3314f3dd 100644 --- a/.github/workflows/build-test-package.yml +++ b/.github/workflows/build-test-package.yml @@ -12,6 +12,7 @@ jobs: with: python3-minor-versions: '["8","11"]' manylinux-platforms: '["_2_28-x64","2014-x64"]' + test-notebooks: true secrets: pypi_password: ${{ secrets.pypi_password }} @@ -21,5 +22,6 @@ jobs: with: python3-minor-versions: '["8","9","10","11"]' manylinux-platforms: '["_2_28-x64","2014-x64"]' + test-notebooks: true secrets: pypi_password: ${{ secrets.pypi_password }} diff --git a/.github/workflows/notebook-test.yml b/.github/workflows/notebook-test.yml deleted file mode 100644 index a8c30d3c..00000000 --- a/.github/workflows/notebook-test.yml +++ /dev/null @@ -1,25 +0,0 @@ -name: Test notebooks - -on: [push, pull_request] - -jobs: - nbmake: - runs-on: ${{ matrix.os }} - strategy: - max-parallel: 3 - matrix: - os: [ubuntu-22.04, macos-12] - steps: - - uses: actions/checkout@v3 - - uses: actions/setup-python@v3 - with: - python-version: '3.9' - - name: Install build dependencies - run: | - python -m pip install --upgrade pip - python -m pip install -r ./.binder/requirements.txt - python -m pip install pytest nbmake - - name: Test notebooks - shell: bash - run: | - pytest --nbmake --nbmake-timeout=3000 examples/*.ipynb