Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output separate images for Hematoxylin and Eosin. #32

Open
Leengit opened this issue Feb 28, 2022 · 1 comment
Open

Output separate images for Hematoxylin and Eosin. #32

Leengit opened this issue Feb 28, 2022 · 1 comment

Comments

@Leengit
Copy link
Collaborator

Leengit commented Feb 28, 2022

This issue is motivated by https://discourse.itk.org/t/itk-error-hematoxylin-and-eosin-are-getting-mixed-up-failed/4767/36

To be determined:

  1. Should these images be produced always or only at the user's request? Tentative answer: only if requested. Incrementally they are very little computational effort; however, including them means that three images are produced rather than just one, and that could be a lot of memory.
  2. Should the normalized image always be produced, or only the two new optional images if that is what the user requests? Tentative answer: let the user decide. Saving the output memory may be valuable to the user.
  3. If the user requests only the two new images, should they be numbered output[0] and output[1] or, alternatively, output[1] and output[2], with the latter case reflecting that the originally supported output[0] is missing from this set of output images. Tentative answer is: output[0] and output[1].
@Leengit
Copy link
Collaborator Author

Leengit commented Mar 8, 2022

Implementation goals:

  1. Is implemented as a distinct filter, StructurePreservingColorSeparationFilter.
  2. Accepts a single input image, but no reference image. That is, no color normalization is performed; if that is desired too, use the StructurePreservingColorNormalizationFilter first.
  3. Produces two output images. The first shows hematoxylin only; that is, it shows what would happen if no eosin stain had been applied. The second output image is vice-versa.
  4. Has much of it implementation via the methods within StructurePreservingColorNormalizationFilter.

This interface is simpler than exposing both functionalities within a single filter. The price is that there will be some redundant computations in the situation that the user wants both color normalization and color separation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant