Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support androidx viewmodel for kotlin multiplatform #1826

Open
Vivecstel opened this issue Mar 21, 2024 · 30 comments
Open

Support androidx viewmodel for kotlin multiplatform #1826

Vivecstel opened this issue Mar 21, 2024 · 30 comments

Comments

@Vivecstel
Copy link

https://developer.android.com/jetpack/androidx/releases/lifecycle#2.8.0-alpha03 added view model support for kotlin multiplatform.
Ideally koin should support this also.
Thanks

@fluttertutorialin
Copy link

Can you explain how to add viewmodel library in kmm

@frankois1234
Copy link

frankois1234 commented Apr 3, 2024

Hello,
some reference here

A full demo how to use viewmodel here :

It should be OK that koin move the viewmodel support to KMP.

@ghost
Copy link

ghost commented Apr 4, 2024

The is the official repo used in google codelabe
https://github.com/MatkovIvan/nav_cupcake

@AbdelrahmanEsam
Copy link

@frankois1234 it doesn't work with koin .... iam getting this error

Uncaught Kotlin exception: org.koin.core.error.InstanceCreationException: Could not create instance for '[Factory:'viewModel class Name']'
at 0 shared

also I am creating this viewModel by factory or single ..... I think koin should support the viewModel{} at the common main

@Leedwon
Copy link

Leedwon commented Apr 9, 2024

@AbdelrahmanEsam

Inspired by https://github.com/MatkovIvan/nav_cupcake/blob/master/composeApp/src/commonMain/kotlin/com/matkovivan/nav_cupcake/ViewModels.kt which uses androidx viewmodel. I'm using the following code to make it work with Koin:

ViewModels.kt in commonMain:

internal expect fun <VM : ViewModel> viewModel(
    modelClass: KClass<VM>,
    factory: ViewModelProvider.Factory = rememberViewModelFactory()
): VM

// Can't be private as it causes Exception during IR lowering
@Composable
internal fun rememberViewModelFactory(): ViewModelProvider.Factory {
    val koin = getKoin()
    return remember {
        viewModelFactory {
            initializer { MyViewModel(myDependency = koin.get()) }
            ... // more VM initializers
        }
    }
}

ViewModels.android.kt in androidMain:

@Composable
internal actual fun <VM : ViewModel> viewModel(
    modelClass: KClass<VM>,
    factory: ViewModelProvider.Factory
): VM = androidx.lifecycle.viewmodel.compose.viewModel(modelClass.java, factory = factory)

ViewModels.ios.kt in iosMain:

@Composable
internal actual fun <VM : ViewModel> viewModel(
    modelClass: KClass<VM>,
    factory: ViewModelProvider.Factory
): VM = androidx.lifecycle.viewmodel.compose.viewModel(modelClass, factory = factory)

And wiring it in the Composables:

@Composable
fun MyScreen(
    myViewModel: MyViewModel = viewModel(MyViewModel::class)
) {

}

I doesn't guarantee that it's the most correct approach, but it works and can be a workaround until Koin officially suports it.

@AbdelrahmanEsam
Copy link

@Leedwon the problem is on the ios side not the android one .... android is working perfectly

class DIHelper : KoinComponent {
private val notesViewModel: NotesViewModel by inject()
private val noteDetailsViewModel: NoteDetailsViewModel by inject()

fun getNotesViewModel(): NotesViewModel = notesViewModel
fun getNoteDetailsViewModel(): NoteDetailsViewModel = noteDetailsViewModel

}

this is my DIHelper in the iosMain to access the viewModels in the ios app

@Leedwon
Copy link

Leedwon commented Apr 9, 2024

@AbdelrahmanEsam I see, I'm using Compose Multiplatform, so for me the setup above does the job on both platforms. But if you are having the setup with separate UIs for iOS and Android, then I think you can take a look at joreilly FantasyPremierLeague, he's using VMs with Koin. I haven't checked the whole thing, but this PR might be helpful.

@AbdelrahmanEsam
Copy link

@Leedwon unfortunately his viewModels doesn't have any other injected dependencies (usecases /repositories) so he just take object from it at the view in ios side

@frankois1234
Copy link

frankois1234 commented Apr 9, 2024

The ViewModel in the common Main is more for the Compose Multiplatform than SwiftUI.

Nothing will change for iOS UIKit/SwiftUI.

The best example is https://github.com/joreilly/FantasyPremierLeague.

Also, the usage of Koin viewmodel in the commonMain must be also for Koin annotation.

@AbdelrahmanEsam
Copy link

@frankois1234 that really doesn't work .... I am using the helper in the ios main module and for the android side everything working perfectly .... but when I am trying to run the ios app koin can't inject the viewModel with the following error

org.koin.core.error.InstanceCreationException: Could not create instance for '[Factory:

@frankois1234
Copy link

This issue is for demanding the implementation of koin ViewModel support in kmp commonMain project, not how to use it.

As the import org.koin.androidx.viewmodel.dsl.viewModel is not available in commonMain project but the import of androidx.lifecycle.ViewModel is now possible with the latest androidx.lifecycle:lifecycle-viewmodel dependancies

@Vivecstel
Copy link
Author

This issue is for demanding the implementation of koin ViewModel support in kmp commonMain project, not how to use it.

As the import org.koin.androidx.viewmodel.dsl.viewModel is not available in commonMain project but the import of androidx.lifecycle.ViewModel is now possible with the latest androidx.lifecycle:lifecycle-viewmodel dependancies

exactly

@AbdelrahmanEsam
Copy link

@frankois1234 I didn't said that I am using it with koin viewModel ..... actually I am creating it with factory or single in koin .... but koin failed to give me my instance

@AbdelrahmanEsam
Copy link

AbdelrahmanEsam commented Apr 10, 2024

@frankois1234 this happen in the ios side only for some reason I really don't know .... in the android side everything working perfectly

@frankois1234
Copy link

@AbdelrahmanEsam Please make another issue, it's not the target of the current one

@marcellogalhardo
Copy link
Contributor

marcellogalhardo commented Apr 17, 2024

@arnaudgiuliani, now that JetBrains has published their artifact (which includes JS and WASM support), we should be able to add official ViewModel KMP support to Koin.

Note that the new artifact is still experimental, so we might want to wait for it to reach a more stable stage, but we can start exploring it and reporting any challenge we may find to JB.

Please see: https://github.com/JetBrains/compose-multiplatform/releases/tag/v1.6.10-beta01

@PMARZV
Copy link

PMARZV commented Apr 17, 2024

Experimental support for koin viewmodel multiplatform would be helpful!

@arnaudgiuliani
Copy link
Member

Great, let's add it for one of next milestone quickly 💪
thanks @marcellogalhardo

@frankois1234
Copy link

@arnaudgiuliani koin annotations will have the support?

@arnaudgiuliani
Copy link
Member

it should be possible yes 👍

@ronjunevaldoz
Copy link

Following this!

@arnaudgiuliani
Copy link
Member

Work in progress: #1875

@arnaudgiuliani
Copy link
Member

Release in 3.6.0-Beta4 🎉

@ColtonIdle
Copy link

ColtonIdle commented May 17, 2024 via email

@agabeyalioglu
Copy link

Hello @arnaudgiuliani i tried 3.6.0-Beta4

factory {
    ListViewModel(get(), get(named(IODispatcher)))
}

I was creating my viewmodel like this previously. Now if i use viewModelOf(::ListViewModel) how can i specify the dispatcher parameter to use named(IODispatcher)?

@DavidGrygar
Copy link

Hi, can I get and use viewModelOf in commonMain if we use SwiftUI on iOS side? What import/imports is needed for this? I have 3.6.0-Beta4 version.

@arnaudgiuliani
Copy link
Member

Hello @arnaudgiuliani i tried 3.6.0-Beta4

factory {
    ListViewModel(get(), get(named(IODispatcher)))
}

I was creating my viewmodel like this previously. Now if i use viewModelOf(::ListViewModel) how can i specify the dispatcher parameter to use named(IODispatcher)?

you need manual dsl then to describe your qualifier and use named.

@arnaudgiuliani
Copy link
Member

Hi, can I get and use viewModelOf in commonMain if we use SwiftUI on iOS side? What import/imports is needed for this? I have 3.6.0-Beta4 version.

For compose MP for now. Still need a bit of work for Swift integration

@frankois944
Copy link

Hi, can I get and use viewModelOf in commonMain if we use SwiftUI on iOS side? What import/imports is needed for this? I have 3.6.0-Beta4 version.

@DavidGrygar
It's not that simple, take a look at https://github.com/joreilly/FantasyPremierLeague and joreilly/FantasyPremierLeague#231.

You can use a Android ViewModel almost like a SwiftUI ViewModel but you need to manage the lifecycle yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests