Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generate-mindmap GHA workflow #570

Open
spier opened this issue Aug 9, 2023 · 1 comment
Open

Fix generate-mindmap GHA workflow #570

spier opened this issue Aug 9, 2023 · 1 comment
Labels
Type - Maintenance / Cleanup Maintaining / cleaning the repo is the main focus of this issue / PR

Comments

@spier
Copy link
Member

spier commented Aug 9, 2023

When running our generate-mindmap GitHub Action workflow, we get these two warnings:

The following actions uses node12 which is deprecated and will be forced to run on node16: swinton/screenshot-website@v1.x. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/Show

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Currently the screenshot of our mindmap still gets generated correctly by the generate-mindmap workflow. However at some point in the not too distant future this will stop working.

Looks like both warnings are related to the swinton/screenshot-website GHA that we are using for generating a screenshot of the HTML generated by markmap. However that GHA does not seem to be maintained anymore, although we are trying to reach the maintainer here.

What options do we have?

  1. switch to another GHA that can create a screenshot from HTML
  2. help fix swinton/screenshot-website and create a new release that we (and others) can use

Option (1) might be the quickest, although (2) would also be neat in the spirit of open source :)

@spier spier added the Type - Maintenance / Cleanup Maintaining / cleaning the repo is the main focus of this issue / PR label Aug 9, 2023
@spier
Copy link
Member Author

spier commented Aug 15, 2023

It looks like the development of swinton/screenshot-website is picking up speed again. So I suggest we wait for a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type - Maintenance / Cleanup Maintaining / cleaning the repo is the main focus of this issue / PR
Projects
None yet
Development

No branches or pull requests

1 participant