Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledging all contributions/contributors #543

Open
spier opened this issue Jun 4, 2023 · 5 comments
Open

Acknowledging all contributions/contributors #543

spier opened this issue Jun 4, 2023 · 5 comments
Labels
⚙️ Type - Meta Improving how we collaborate in this repo is the main focus of this issue / PR

Comments

@spier
Copy link
Member

spier commented Jun 4, 2023

GitHub has a way to show the people that committed (code) to this project. However by default only very few people are shown, and there is no further information about what they have contributed either.

Screenshot 2023-06-04 at 12 37 25

As our community grows, it would be great to acknowledge the broad range of people that are supporting our patterns in all sorts of ways, not just the ones contributing code/patterns.

Implementation thoughts

I have heard good things about the all-contributors spec and bot but I don't know how it works in practice.

Their claim is:

Recognize All Contributors - Including those that don't push code

However their documentation looks like users need a GitHub handle to be added as contributors, which seems counter intuitive.

I am taking inspiration from The Turing Way project, who are using the tool for years.
We could review their implementation notes. Some links to get started:

@spier spier added the ⚙️ Type - Meta Improving how we collaborate in this repo is the main focus of this issue / PR label Jun 4, 2023
@CiaraFlanagan
Copy link
Contributor

I've been meaning to bring this up!

I heard good things about this bot the other week but I have no direct knowledge myself ... The Turing Way project use it to celebrate their contributors.

@da5nsy
Copy link

da5nsy commented Jun 15, 2023

Just flagging that since the-turing-way/the-turing-way#3093 there's been a slight change in how The Turing Way handles this. Read about it here: https://the-turing-way.netlify.app/community-handbook/infrastructure/infrastructure-contributors.html (if you just want to display the contributors on a readme page this level of complexity isn't necessary)

@spier
Copy link
Member Author

spier commented Jun 16, 2023

Thank you for chiming in here @da5nsy, this is helpful context!
I think that our first version of this might start with the most simple approach.

Putting two more questions here if I may. If you have any more experience with this, we would love to hear it.

  1. Is it true that for the all-contributors spec/bot to work, the user that we want to acknowledge needs a GitHub handle?
  2. For a long-lived project like ours, how to go about seeding the list of contributors with everybody that has already contributed in the past? Creating a PR for every single one seems like a really tough way to do this.

Thank you for sharing!

@da5nsy
Copy link

da5nsy commented Jun 16, 2023

Is it true that for the all-contributors spec/bot to work, the user that we want to acknowledge needs a GitHub handle?

That's my understanding. Though I'm not certain.

Creating a PR for every single one seems like a really tough way to do this.

I think you have 2 options, either edit it manually to add lots of people (maybe add a couple with the bot first so you can just copy the formatting), or add multiple people in a single PR.
There might be more automated ways, but I haven't come across them.

@spier
Copy link
Member Author

spier commented Aug 23, 2023

Just noticed that we have had this idea in this repo before :)
#219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Type - Meta Improving how we collaborate in this repo is the main focus of this issue / PR
Projects
None yet
Development

No branches or pull requests

3 participants