Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment slug bug when set to "overview" #1585

Open
Grraahaam opened this issue Mar 18, 2024 · 1 comment 路 May be fixed by #1632
Open

Environment slug bug when set to "overview" #1585

Grraahaam opened this issue Mar 18, 2024 · 1 comment 路 May be fixed by #1632

Comments

@Grraahaam
Copy link
Contributor

Describe the bug 馃

When setting the environment slug to overview, it'll overlap with the secret overview page in the URL.

When navigating through "clicks" switching pages works great in-app, but when copy/pasting the URL or just by refreshing you'll always end up on the secret overview page and not on the correct environment page with the overview slug

To Reproduce 馃捇

  1. Go to https://app.infisical.com/project/<project-id>/settings
  2. In the "Environment" section, edit/create an environment (e.g. foo) with the overview slug
  3. Go back to the secret overview page and "explore" the foo environment (https://app.infisical.com/project/<project-id>/secrets/overview)
  4. See the same URL as the page just before
  5. Refresh and see the error, you'll get back to the overview page

Expected behavior 馃攷

A project's environment URL should always lead you to the correct page. Some slugs should be reserved keywords or another logic should be implemented.

E.g. refactoring the overview path to https://app.infisical.com/project/<project-id>/overview and keeping the trailing .../secrets/ for environment slugs:

  • https://app.infisical.com/project/<project-id>/overview
  • https://app.infisical.com/project/<project-id>/secrets/<env-slug>

This could prevent this bug

Screenshots 馃帹

env-slug

Platform you are having the issue on

Infisical Cloud + self-hosted

@Ponnada96
Copy link

Hi @akhilmhdh , I would like to work on this issue. Could you please assign it to me?

@Ponnada96 Ponnada96 linked a pull request Mar 27, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants