Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix R CMD CHECK notes #97

Open
annakrystalli opened this issue Feb 29, 2024 · 2 comments
Open

Fix R CMD CHECK notes #97

annakrystalli opened this issue Feb 29, 2024 · 2 comments

Comments

@annakrystalli
Copy link
Collaborator

Although our actions are passing, there are three notes wehn running R CMD CHECK that would need addressing prior to any CRAN submission:

── R CMD check results ─────────────────── hubEnsembles 0.0.0.9002 ────
Duration: 19.1schecking for portable file names ... NOTE
  Found the following non-portable file paths:
    hubEnsembles/inst/example-data/example-simple-forecast-hub/model-output/UMass-ar/2022-11-28-UMass-ar.csv
    hubEnsembles/inst/example-data/example-simple-forecast-hub/model-output/UMass-ar/2022-12-05-UMass-ar.csv
    hubEnsembles/inst/example-data/example-simple-forecast-hub/model-output/UMass-ar/2022-12-12-UMass-ar.csv
    hubEnsembles/inst/example-data/example-simple-forecast-hub/model-output/UMass-gbq/2022-11-28-UMass-gbq.csv
    hubEnsembles/inst/example-data/example-simple-forecast-hub/model-output/UMass-gbq/2022-12-05-UMass-gbq.csv
    hubEnsembles/inst/example-data/example-simple-forecast-hub/model-output/UMass-gbq/2022-12-12-UMass-gbq.csv
    hubEnsembles/inst/example-data/example-simple-forecast-hub/model-output/simple_hub-baseline/2022-11-28-simple_hub-baseline.csv
    hubEnsembles/inst/example-data/example-simple-forecast-hub/model-output/simple_hub-baseline/2022-12-05-simple_hub-baseline.csv
    hubEnsembles/inst/example-data/example-simple-forecast-hub/model-output/simple_hub-baseline/2022-12-12-simple_hub-baseline.csv
  
  Tarballs are only required to store paths of up to 100 bytes and cannot
  store those of more than 256 bytes, with restrictions including to 100
  bytes for the final component.
  See sectionPackage structurein theWriting R Extensionsmanual.checking installed package size ... NOTE
    installed size is  6.5Mb
    sub-directories of 1Mb or more:
      doc            3.8Mb
      example-data   2.6Mbchecking R code for possible problems ... NOTE
  linear_pool: no visible binding for global variableoutput_typelinear_pool_quantile: no visible binding for global variableoutput_type_idlinear_pool_quantile: no visible binding for global variablevaluelinear_pool_quantile: no visible binding for global variablepred_qsvalidate_output_type_ids: no visible binding for global variableoutput_typevalidate_output_type_ids: no visible binding for global variablemodel_idvalidate_output_type_ids: no visible binding for global variableoutput_type_idUndefined global functions or variables:
    model_id output_type output_type_id pred_qs value
@lshandross
Copy link
Contributor

Notes about portable file names and package size will be fixed once the vignette is updated with the relevant parts from the finalized version of the manuscript. The no-visible binding for global variable(s) note has been fixed.

@elray1
Copy link
Contributor

elray1 commented Mar 11, 2024

Noting that since those data frame columns are not actually global variables defined by the package, a cleaner solution to that issue than the one implemented in #97 is to import .data from rlang and then use .data$<column name> to refer to the column. There is some documentation of this here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: On hold
Development

No branches or pull requests

3 participants