Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyntaxError in generated OpenAPI client #35

Open
thSoft opened this issue Oct 14, 2020 · 3 comments
Open

SyntaxError in generated OpenAPI client #35

thSoft opened this issue Oct 14, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@thSoft
Copy link
Member

thSoft commented Oct 14, 2020

Steps to reproduce:

  • Spin up a notebook in this repo with MyBinder
  • Try to execute the first Python code block

Expected output: it is executed successfully

Actual output:

  File "/srv/conda/envs/notebook/lib/python3.7/site-packages/mms_python_client/api/artifact_api.py", line 137
    async=params.get('async'),
        ^
SyntaxError: invalid syntax

Cause: async became a reserved word in Python 3.7, but we use it for the async method family.

@thSoft thSoft added the bug Something isn't working label Oct 14, 2020
@abelhegedus
Copy link
Member

@bergmanngabor
Copy link
Member

bergmanngabor commented Nov 6, 2020

Solved for now in the MyBinder setup: a207daf

It seems the mms client package must be pinned to version 3.4.2.1 until a fix is available upstream.

TODO:

  • report to MMS guys
  • update readme / setup guide in the meantime
  • update declared package dependencies (pip, conda) in the meantime

@bergmanngabor
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants