Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Degraded state? #63

Open
tangtony opened this issue May 23, 2019 · 2 comments
Open

Degraded state? #63

tangtony opened this issue May 23, 2019 · 2 comments
Labels
feature request v3 version 3
Projects
V3

Comments

@tangtony
Copy link

When a non-fatal check fails, the top level status is still "ok". Is the intent that you have to check each component for success in order to determine if the service is actually 100% ok?

Would it be possible to add support for a degraded state or something along the lines of "there are failures, but nothing fatal"?
@schigh
Copy link
Contributor

schigh commented Sep 26, 2019

@tangtony apologies for the late response.

I do like this idea. Could you maybe expand upon it a bit? I'm thinking in terms of how to best use that information in a consumer...a readiness probe for example. How could we unambiguously say "there are some failures, but nothing fatal" to a listening process?

@schigh schigh added the v3 version 3 label Oct 3, 2019
@schigh schigh added this to Feature in V3 Oct 3, 2019
@dselans
Copy link
Contributor

dselans commented Jan 31, 2021

I think that's exactly it - if a non-fatal service fails, then the lib can return a 2xx (other than 200) and a JSON status of degraded. Seems legit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request v3 version 3
Projects
V3
  
Feature
Milestone
No milestone
Development

No branches or pull requests
3 participants
@schigh @dselans @tangtony