Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating vcfdist as a comparison engine into hap.py #173

Open
TimD1 opened this issue Apr 5, 2023 · 0 comments
Open

Integrating vcfdist as a comparison engine into hap.py #173

TimD1 opened this issue Apr 5, 2023 · 0 comments

Comments

@TimD1
Copy link

TimD1 commented Apr 5, 2023

I've recently released vcfdist as an alternative comparison engine to vcfeval or xcmp. In summary, it benefits from standardizing variant representations, requiring local (but not global) phasing of variants, and giving partial credit for variant calls which are mostly (but not exactly) correct. For more information, you can find the code here and pre-print here.

I just added support for intermediate GA4GH VCF benchmarking summary files, as described in Supplementary Note 3 of "Best practices for benchmarking germline small-variant calls in human genomes". I have verified that hap.py's qfy.py is able to correctly process vcfdist's intermediate VCF file for stratified variant comparison, and have included an example here.

Is there any process for getting a new benchmarking comparison engine integrated into hap.py? I would be happy (no pun intended) to put in the effort and submit a PR, but I would like to first verify that this repository is still actively maintained and the developers would welcome adding a new comparison engine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant