Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge points & check-in pages #9

Open
gracewzhang opened this issue Jan 24, 2023 · 1 comment · May be fixed by #18
Open

Merge points & check-in pages #9

gracewzhang opened this issue Jan 24, 2023 · 1 comment · May be fixed by #18
Assignees

Comments

@gracewzhang
Copy link
Member

gracewzhang commented Jan 24, 2023

Overview

  • The points component should look similar to how it does now except it'll take up the bottom half of the check-in page
  • After checking in, the points component should rerender & display the event you just checked in for
  • The points component should have a border & header (the header being "Points") similar to the "Event key" box
    • The body should be the list of events like what you see right now (keep it as is)
    • The component should be scrollable, not the page (so there's a scrollbar within the component)

Guidelines/Tips

  • Start by extracting check-in & points into separate components (so they're no longer pages)
    • The Check-In component is just the box containing the "Event key" header + input + button
  • Rename the Check-In page to Home
  • Home should contain the Check-In and Points components you extracted
  • Your best frame of reference is the other components in the repo!
@3sannasia 3sannasia linked a pull request Mar 21, 2023 that will close this issue
@3sannasia
Copy link
Collaborator

Modifications made based on comments:

add "home" header outside of the 2 boxes
rename "home" in the check in box to "check in"
increased spacing between check in & points boxes
Made home bigger than the check in and points heading

Screenshot 2023-04-11 at 5 54 13 PM

Checked dark mode functionality as well:

Screenshot 2023-04-11 at 5 54 02 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants