Adding Pset_Address to a building #3228
Replies: 2 comments 4 replies
-
|
I tried various things, but I couldn't get a RecursionError to pop up. Can you maybe share full working code? In my test the tuple get serialized into a string as a single label. Looking at the code around here https://github.com/IfcOpenShell/IfcOpenShell/blob/v0.7.0/src/ifcopenshell-python/ifcopenshell/api/pset/edit_pset.py#L258 there will be various things that need changing, like testing for (tuple, list) instead of just list, and more importantly supporting IfcPropertyListValue. Is this something you'd perhaps like to contribute to? |
Beta Was this translation helpful? Give feedback.
-
|
I see, the tuple error happened because I didn't specify the schema version, makes sense, it must be So I tried to manually create an instance of address_lines = run("root.create_entity", model, ifc_class="IfcPropertyListValue")But I got a new error: address_lines = model.create_entity("IfcPropertyListValue")and this time it worked. Not sure why I couldn't create it via address_lines.ListValues = [
model.create_entity("IfcLabel", "foo"),
model.create_entity("IfcLabel", "bar"),
model.create_entity("IfcLabel", "egg")
]
run(
"pset.edit_pset",
model,
pset=pset,
properties={
"Country": "Test Country",
"Region": "Test Region",
"Town": "Test City",
"AddressLines": address_lines
}
)@aothms thanks for guiding me in the right direction. I definitely would like to contribute in the future, right now my understanding of ifc and this lib may not be enough, but if I figure out a way to make
|
Beta Was this translation helpful? Give feedback.
-
|
Hmm, but when I'm trying to read the new psets, I'm getting an error: psets = get_psets(building, psets_only=True)
UPD: |
Beta Was this translation helpful? Give feedback.
-
|
Yep, the I think adding the Alternatively we restructure the statement altogether and really check whether the type given is actually a data type that is acceptable as an IfcPropertySingleValue.NominalValue (a type named IfcValue) or that it is a subtype of property definition At least indeed in get_psets() IfcPropertyListValue seems properly handled IfcOpenShell/src/ifcopenshell-python/ifcopenshell/util/element.py Lines 219 to 220 in fa4e19e |
Beta Was this translation helpful? Give feedback.
-
|
Let me rephrase to make sure I got it right, since I'm new to ifc :) If I understand your idea correctly, we end up with 3 paths:
(could also use If that is your idea, then I like it more, and it sounds easy enough to do even for me heh. |
Beta Was this translation helpful? Give feedback.
-
Yes this is somewhat unfortunate naming, but api.create_entity() is not intended for arbitrary classes, see the note here: https://github.com/IfcOpenShell/IfcOpenShell/blob/v0.7.0/src/ifcopenshell-python/ifcopenshell/api/root/create_entity.py#L27-L29
This is exactly what the template provides. It basically represents the page you see here https://ifc43-docs.standards.buildingsmart.org/IFC/RELEASE/IFC4x3/HTML/lexical/Pset_Address.htm with
i.e IfcPropertyListValue of IfcLabel in computer interpretable form. See below: |
Beta Was this translation helpful? Give feedback.
-
I'm experimenting on generating ifc models, currently I'm stuck at adding an address to a building, this is what I'm trying to do:
When
AddressLinesis a tuple, I'm gettingRecursionError: maximum recursion depth exceeded in comparison, when it's a list, I'm gettingAttributeError: 'NoneType' object has no attribute 'HasPropertyTemplates'. If I set it to a string, it works, but doesn't appear to be correct according to building smart, correct me if I'm wrong.So my question is, am I doing it wrong, or is there a bug? Or maybe I must define my own
pset_template?Beta Was this translation helpful? Give feedback.
All reactions