Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change color of navigation icons in gallery view #156

Open
elioqoshi opened this issue Jul 10, 2018 · 5 comments
Open

change color of navigation icons in gallery view #156

elioqoshi opened this issue Jul 10, 2018 · 5 comments
Labels
1. Frontend This issue is related with the frontend of Identihub 2. papercut Small non-breaking bugs which appear often 3. good first issue Easily fixable 3. help wanted We need help to fix this issue
Milestone

Comments

@elioqoshi
Copy link
Contributor

In the test branch the navigation icons in gallery view are problematic if the background color is close to the icon color:

image

Can we change the color of the icons (back, forward, close) to gray ( #808080 ) with 50% opacity? That would cover most use cases (unless it's the same gray).

An alternative could be to give it a Invert Blending Mode effect

@elioqoshi elioqoshi added 3. help wanted We need help to fix this issue 3. good first issue Easily fixable 1. Frontend This issue is related with the frontend of Identihub 2. papercut Small non-breaking bugs which appear often labels Jul 10, 2018
@kominoshja
Copy link

I would vote for the Invert Blending Mode, as it is adaptable with every color.

@albanafmeti
Copy link

Dependent by #154

@albanafmeti
Copy link

@elioqoshi @Borisbudini
Check the new implemented VIEWER PAGE, and if everything is fine, close this issue.

@kominoshja
Copy link

@albanafmeti the issue still seems to occur on #494949 and #585a51

@elioqoshi
Copy link
Contributor Author

There are white borders which don't recieve any background color assigned to that asset:

image

The background color should be for the whole viewer, like in this mockup here:
image

@albanafmeti can you double check this?

@kominoshja kominoshja added this to the v1.0 milestone Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. Frontend This issue is related with the frontend of Identihub 2. papercut Small non-breaking bugs which appear often 3. good first issue Easily fixable 3. help wanted We need help to fix this issue
Projects
None yet
Development

No branches or pull requests

3 participants