Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reimplement sortable drag'n'drop cards component for admin view #150

Open
elioqoshi opened this issue Jun 22, 2018 · 5 comments
Open

reimplement sortable drag'n'drop cards component for admin view #150

elioqoshi opened this issue Jun 22, 2018 · 5 comments
Labels
1. Frontend This issue is related with the frontend of Identihub
Milestone

Comments

@elioqoshi
Copy link
Contributor

Currently the implementation of the sortable drag'n'drop cards component is done from scratch and doesn't work very smoothly and intuitively. We should reimplement the component with something along the lines of the Grid component here:

http://clauderic.github.io/react-sortable-hoc/#/basic-configuration/grid?_k=3cu5am

This is only available in the admin view obviously.

@elioqoshi elioqoshi added the 1. Frontend This issue is related with the frontend of Identihub label Jun 22, 2018
@elioqoshi elioqoshi added this to the v0.8 milestone Jun 22, 2018
@albanafmeti albanafmeti added the 4. in progress This issue is being worked on label Jun 22, 2018
@kominoshja
Copy link

This has some problems on implementation and needs more time. Removing milestone.

@kominoshja kominoshja removed this from the v0.8 milestone Jul 29, 2018
@albanafmeti albanafmeti removed the 4. in progress This issue is being worked on label Jul 31, 2018
@kominoshja kominoshja added this to the v1.0 milestone Aug 16, 2018
@kominoshja
Copy link

Maybe this works? @albanafmeti
http://cheton.github.io/react-sortable/

@albanafmeti
Copy link

@elioqoshi needs to confirm if that's fine.

@elioqoshi
Copy link
Contributor Author

elioqoshi commented Aug 25, 2018

No, that looks almost worse than what we have right now.

@keunes
Copy link

keunes commented Sep 13, 2018

For me (end user with very limited tech background), drag-n-drop looks & works nice, when it works. I wouldn't necessarily change the 'how' but rather the stability: sometimes I can't use drag-n-drop anymore after using it once. Refreshing the page will re-enable it.

[Edit] Also (not sure if it should get its own ticket), drag-n-drop of sections would be a welcome addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. Frontend This issue is related with the frontend of Identihub
Projects
None yet
Development

No branches or pull requests

4 participants