Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonRpcConnection#Send*() queues messages in memory even after #Disconnect() #9985

Open
Al2Klimov opened this issue Feb 1, 2024 · 2 comments · May be fixed by #9991
Open

JsonRpcConnection#Send*() queues messages in memory even after #Disconnect() #9985

Al2Klimov opened this issue Feb 1, 2024 · 2 comments · May be fixed by #9991
Assignees
Labels
area/distributed Distributed monitoring (master, satellites, clients) bug Something isn't working ref/IP

Comments

@Al2Klimov
Copy link
Member

Al2Klimov commented Feb 1, 2024

Describe the bug

  1. JsonRpcConnection#Send*() posts a closure with the message in question into its strand which processes such sequentially
  2. That closure inserts the message into #m_OutgoingMessagesQueue

Especially ApiListener#ReplayLog() fills it aggressively. After some time that queue is emptied by #WriteOutgoingMessages(). Unless it's been stopped, either by itself or by #Disconnect().

Expected behavior

Additional context

ref/IP/48306
ref/IP/52366

@Al2Klimov Al2Klimov added bug Something isn't working area/distributed Distributed monitoring (master, satellites, clients) ref/IP labels Feb 1, 2024
@Al2Klimov
Copy link
Member Author

@lippserd Admittedly this was already present in v2.11.x with the new network stack, same for what actually fills our queues:

@Al2Klimov
Copy link
Member Author

Btw. also an unnecessary in-memory queue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/distributed Distributed monitoring (master, satellites, clients) bug Something isn't working ref/IP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant