Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AudioCallbackDriver no longer exists #86

Open
jim3692 opened this issue Dec 26, 2023 · 1 comment · May be fixed by #87
Open

AudioCallbackDriver no longer exists #86

jim3692 opened this issue Dec 26, 2023 · 1 comment · May be fixed by #87
Assignees
@jim3692 @IceDBorn
Labels
bug Something isn't working enhancement New feature or request

Comments

@jim3692
Copy link
Collaborator

jim3692 commented Dec 26, 2023

It looks like in Firefox 121, the input nodes are no longer named AudioCallbackDriver, but they have the name of the tab or the frame which contains the call, in the media.name field.

Maybe we could utilize the injected script to get the title of the page and add it to the ignore list.
@IceDBorn IceDBorn added bug Something isn't working enhancement New feature or request labels Dec 26, 2023
@IceDBorn IceDBorn added this to the 0.4.0 milestone Dec 26, 2023
@jim3692 jim3692 linked a pull request Dec 27, 2023 that will close this issue
Draft
@pallaswept
Copy link

pallaswept commented Dec 27, 2023 •
edited

This is potentially game-changing. I don't know about Gnome, but KDE's Dbus interface will allow us to grab the name of the video window that is being captured, so no need to manually select the audio input though the popup in firefox, we can automatically link the audio from the window that's been selected to share.

image

Edit: y'know....in theory,,,,,,,, maybe. But it's a lot better than a generic name that never changes.
Disclaimer: No I am not broadcasting copyrighted stuff, amazon, I just clicked the first video I saw to demo it :)

@IceDBorn IceDBorn pinned this issue Dec 28, 2023
@IceDBorn IceDBorn removed this from the 0.4.0 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jim3692 jim3692

@IceDBorn IceDBorn

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing AudioCallbackDriver IceDBorn/pipewire-screenaudio
3 participants
@jim3692 @IceDBorn @pallaswept