Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variance parameter as an input in ITHACAdict #468

Open
sirbugur opened this issue Nov 23, 2021 · 0 comments
Open

Variance parameter as an input in ITHACAdict #468

sirbugur opened this issue Nov 23, 2021 · 0 comments

Comments

@sirbugur
Copy link

Is your feature request related to a problem? Please describe.
When initializing a ROM from a ITHACAdict, maybe variance of the snapshots could be implemented as an input. In this way, users don't require to explicitly define number of POD snapshots and leave it to code.

Describe the solution you'd like
"NmodesXout" defines how many modes will be calculated by code. Adding sth like:
"NmodesXout_variance" which can take a float as input. Ex : 0.90 means 90% of data should be represented, so return as minimum number of required snapshots as possible.

Describe alternatives you've considered
Iterative function should be created utilizing LRSensitivity::getXstats() function. Also, another overridable ITHACAPOD::getModes(...) should be defined aligned with "NmodesXout_variance".

Additional context
This feature acts like explained_variance_ratio_ property of sklearn PCA class. Please find following link for detailed explanation.
https://scikit-learn.org/stable/modules/generated/sklearn.decomposition.PCA.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant