Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRA conversion - if dates in tab are ISO8601 they are not passed to SRA output #65

Open
djcomlab opened this issue Jul 14, 2016 · 4 comments

Comments

@djcomlab
Copy link
Member

I noticed that if you format dates (submission date and public release date) into the ISO8601 format, the SRA converter seems to ignore them, when using BII-S-7. To get the converter to pick them up you need to have in formate dd/mm/yyyy, which is not ideal.

@proccaserra
Copy link
Member

could be linked to the fact that ISAcreator does not enforce ISO8601 in Date fields. something we should address

@djcomlab
Copy link
Member Author

The dd/mm/yyyy does however make it easier for data entry for the user. Strictly speaking the spec says it should be ISO8601, and the date formatting is picked up by the validators, but I guess we could make the lower level tools strict and perhaps user tools transparent to the strictness?

@proccaserra
Copy link
Member

+1, the UI should present a calendar and user's selection is saved in the ISA specified/expected format. does java calendar to ISO 8601 exist?

@djcomlab
Copy link
Member Author

I believe it's possible to map any Java Date object to any format we like and there's some in-built formatters for this, so I'm sure it can be done to ISO 8601 also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants