Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case when the Maintainer is not a student #10

Open
pradumangoyal opened this issue Aug 19, 2020 · 3 comments
Open

Handle the case when the Maintainer is not a student #10

pradumangoyal opened this issue Aug 19, 2020 · 3 comments
Assignees

Comments

@pradumangoyal
Copy link
Member

Currently, implementation of the get_rights_for_semester in the file /utils.rights.py is on the assumption that a maintainer should be a student. But as there can be maintainers with no other roles, it should handle the case too.

My suggestion would be to pass a callback bool (defaults to False) in the function get_rights_for_semester(user, semester_no, right_if_not_student) which should be returned if the user is a maintainer but not a student.

@GopalGupta8216
Copy link
Contributor

assign it to me

@algomaster99
Copy link
Member

@GopalGupta8216 feel free to take this up

@pradumangoyal
Copy link
Member Author

@GopalGupta8216 any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants