Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming #5

Open
js6pak opened this issue Feb 23, 2024 · 5 comments
Open

Consider renaming #5

js6pak opened this issue Feb 23, 2024 · 5 comments
Assignees

Comments

@js6pak
Copy link
Contributor

js6pak commented Feb 23, 2024

Having a GitHub. prefix makes it look like it's an official GitHub project, which it's not.
The fact that the c# project name, nuget package id and github repository names are all different is quite bizzare aswell.
My vote goes for ActionsToolkitSharp.

@IEvangelist
Copy link
Owner

Yeah, I was back and forth a lot on the naming. The GitHub. prefix isn't reserved, so I went with that. What about GitHubActions. instead?

@js6pak
Copy link
Contributor Author

js6pak commented Feb 23, 2024

GitHubActions. still sounds too generic, I feel like having a more unique name for the project would be both less confusing and better for searchability.

@IEvangelist
Copy link
Owner

GitHubActions. still sounds too generic, I feel like having a more unique name for the project would be both less confusing and better for searchability.

I was referring specifically to the NuGet package and project names:

Current name Proposed name
GitHub.Actions.Core GitHubActions.Core
GitHub.Actions.Glob GitHubActions.Glob
GitHub.Actions.Octokit GitHubActions.Octokit

I'm not a fan of the suffix *Sharp in the name and Toolkit might make sense. Maybe something like this: GitHubActions.Toolkit.Core?

@js6pak
Copy link
Contributor Author

js6pak commented Feb 26, 2024

At least for me, GitHubActions.Toolkit.Core seems to suggest that it's the Core subcomponent of the Toolkit library owned by the GitHubActions organization.

Something like GitHubActionsToolkit.Core where Core is the subcomponent of GitHubActionsToolkit library would work better. It's still a little generic but it should be fine.

@IEvangelist IEvangelist self-assigned this Feb 26, 2024
@IEvangelist
Copy link
Owner

Yeah, I'm good with that. I'll make the name change soon. Thanks for the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants