Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination in the get all operation #5

Open
jwalcorn opened this issue Feb 25, 2022 · 0 comments
Open

Add pagination in the get all operation #5

jwalcorn opened this issue Feb 25, 2022 · 0 comments

Comments

@jwalcorn
Copy link
Member

Today if you do a GET /broker/, that returns all of the brokers that exist. That's fine if you only have a few, but if you had thousands or more, this isn't a good idea, as we could run the server out of memory, response time could be too long, etc. Need to add a way to ask for the first 20 or 100 or whatever, then ask for the next page in a separate REST call, etc. Of course, this means the downstream microservices, like Portfolio and Account, would similarly need such pagination. We'd probably also need to add some kind of "order by" support, to make sure we get the same first 100 from Portfolio that we get from Account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant