Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit-conversion on non-existing data does not raise DimensionalityError #776

Open
danielhuppmann opened this issue Aug 29, 2023 · 0 comments

Comments

@danielhuppmann
Copy link
Member

The pint-package (used by the convert_unit() method) raises a dimensionality error if the units cannot be converted.

However, if a user applies the method convert_unit("source_unit", "target_unit") and the IamDataFrame does not have any data with "source_unit" the validation is skipped.

It would be safer to check whether a unit-conversion is valid even if no data exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant