Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Ignore auto update for hp games if they are access code gated #886

Merged
merged 3 commits into from
May 15, 2024

Conversation

BrettCleary
Copy link
Collaborator

@BrettCleary BrettCleary commented May 13, 2024

If a HP game is access code gated, ignore the auto update. The game can still be manually updated by clicking the update button and then the update modal should show with a text input to enter a new one time use access code

tests

closes #882

@BrettCleary BrettCleary added the PR: Ready-For-Review PR is ready to be reviewed by peers label May 13, 2024
@BrettCleary BrettCleary self-assigned this May 13, 2024
Copy link
Contributor

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff

@BrettCleary BrettCleary added PR: Ready-For-Test PR is ready to be tested by a QA and removed PR: Ready-For-Review PR is ready to be reviewed by peers labels May 15, 2024
Copy link

@nyghtstalker nyghtstalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I confirmed with Kosium and Iron Works that gated games are not part of the auto-update.
  • I confirmed that auto-updates still work on non-gated games.

@BrettCleary BrettCleary merged commit 7553c58 into main May 15, 2024
15 of 16 checks passed
@BrettCleary BrettCleary deleted the fix/ignore_access_code_auto_update branch May 15, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to auto update Iron Works
5 participants