Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropout serialization missing #71

Open
theedge456 opened this issue Jul 27, 2018 · 1 comment
Open

dropout serialization missing #71

theedge456 opened this issue Jul 27, 2018 · 1 comment

Comments

@theedge456
Copy link

I noticed that the serialisation of the type Dropout was missing on the release 0.1.0, preventing from saving and loading a trained network.
The workaround is to apply the trick described here. The problem is that it works only for ghc>=7.2.1.
Tell me if you prefer to add a fix for any ghc release or if I may pull my fix.

@HuwCampbell
Copy link
Owner

Thanks for the issue, sorry I didn't notice it earlier.

The dropout layers themselves aren't actually fully implemented, so I wasn't super worried that they weren't persisted.

I'll add a serialisation instance for them and actually try to get them going properly. The difficulty is that there's implicit randomness in a dropout layer, and I didn't want to put effects in which would pollute the purity of system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants