Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked area plot for Icecup, extra denominator #153

Open
HighDiceRoller opened this issue Mar 4, 2023 · 1 comment
Open

Stacked area plot for Icecup, extra denominator #153

HighDiceRoller opened this issue Mar 4, 2023 · 1 comment
Labels

Comments

@HighDiceRoller
Copy link
Owner

HighDiceRoller commented Mar 4, 2023

In some cases we may want to plot dice that effectively have a denominator greater than the sum of the quantities, i.e. there is some amount of "missing" quantity that was filtered out. I'm not sure yet whether there are use cases for this outside of plotting.

Package-side options:

  • A variant of reroll() / filter() that removes outcomes but not their contribution to the denominator.
    • A variant of the Reroll object that does the same.
  • A variant of reroll() / filter() that also returns the removed quantity.

The trouble is there's not really been use for this so far, and it would touch a large portion of the codebase.

Icecup-side options:

  • A separate denominator or filter argument for output() and area().
  • Expect outcomes to area to be (actual_outcome, filter).
  • Global function similar to matplotlib xlim to set the range.
@HighDiceRoller HighDiceRoller changed the title Stacked area plot for Icecup Stacked area plot for Icecup, extra denominator Mar 5, 2023
@HighDiceRoller
Copy link
Owner Author

HighDiceRoller commented Mar 11, 2023

I went with the limit approach for Icecup, since I think it will be rare to want to exclude outcomes in the middle, and at the same time choosing a side to exclude from is beneficial for plotting the CDF / SF. This approach also dodges the normalization question.

There's still an issue with e.g. this situation. Using chart.js stack probably won't work well with CDF / SF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant