Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved MPV fit #32

Open
153957 opened this issue Sep 3, 2014 · 5 comments
Open

Improved MPV fit #32

153957 opened this issue Sep 3, 2014 · 5 comments

Comments

@153957
Copy link
Member

153957 commented Sep 3, 2014

The current MPV fit is nice and fast, but the algorithm makes some assumptions which cause it to fail in some cases.
Attempts have been made to improve the algorithm (see the mpv-subtract-powerlaw branch). However, while these works better in some cases, it doesn't work in others..

In this issue a list of cases will be compiled that the algorithm should (or should not) be able to find the MPV in. In the cases where it should not find the MPV it should return the error value (-999).

@153957
Copy link
Member Author

153957 commented Sep 3, 2014

Should find MPV

I have split this in 2 and 4 detectors since they have different triggering condictions, which affect the shape of the pulse integral histogram.

4 detectors

  • 501 2014/9/2 (data, csv)
  • 503 2014/9/2 (data, csv) - except detector 2

2 detectors

Should not find MPV

... Please add more interesseting situations/cases to get a more complete sample.

@davidfokkema
Copy link
Member

Good idea! The links don't work correctly? Make this a task list so that we know for which cases the current algorithm fails?

@153957
Copy link
Member Author

153957 commented Sep 6, 2014

Links are fixed.

Indeed, and perhaps also a list of the kind of special cases that might be encountered.

@153957 153957 closed this as completed Sep 6, 2014
@153957 153957 reopened this Sep 6, 2014
@tomkooij
Copy link
Member

station 105 from sep 2015 up until mar 2016 fails the MPV fit. Probably because of strange PMT voltages (strange pulseintegrals histograms):

download
http://data.hisparc.nl/show/stations/105/2016/1/1/

I am investigating (https://github.com/tomkooij/lio-project/tree/master/offsets_zaanstad) but this should be "fixable". The fit fails due to the initial_guess.

153957 referenced this issue in HiSPARC/publicdb Jul 22, 2018
Pulseheight monitor service is not enabled for any station.
Model is not very efficient (separate object per detector).
Fit routines should be in SAPPHiRE.
Should use integrals instead of pulse heights.
@153957
Copy link
Member Author

153957 commented Jul 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants