New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved MPV fit #32
Comments
Should find MPVI have split this in 2 and 4 detectors since they have different triggering condictions, which affect the shape of the pulse integral histogram. 4 detectors2 detectorsShould not find MPV... Please add more interesseting situations/cases to get a more complete sample. |
Good idea! The links don't work correctly? Make this a task list so that we know for which cases the current algorithm fails? |
Links are fixed. Indeed, and perhaps also a list of the kind of special cases that might be encountered. |
station 105 from sep 2015 up until mar 2016 fails the MPV fit. Probably because of strange PMT voltages (strange pulseintegrals histograms):
I am investigating (https://github.com/tomkooij/lio-project/tree/master/offsets_zaanstad) but this should be "fixable". The fit fails due to the initial_guess. |
Pulseheight monitor service is not enabled for any station. Model is not very efficient (separate object per detector). Fit routines should be in SAPPHiRE. Should use integrals instead of pulse heights.
Some branches in which some work on this was performed, but were never finished/merged: https://github.com/HiSPARC/sapphire/tree/mpv_fit |
The current MPV fit is nice and fast, but the algorithm makes some assumptions which cause it to fail in some cases.
Attempts have been made to improve the algorithm (see the
mpv-subtract-powerlaw
branch). However, while these works better in some cases, it doesn't work in others..In this issue a list of cases will be compiled that the algorithm should (or should not) be able to find the MPV in. In the cases where it should not find the MPV it should return the error value (-999).
The text was updated successfully, but these errors were encountered: