Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4detector station can and do recieve configs without slave and break #192

Open
tomkooij opened this issue Nov 4, 2019 · 2 comments
Open

Comments

@tomkooij
Copy link
Member

tomkooij commented Nov 4, 2019

Stations with master/slave (4 detectors) can recieve erroneous config messages without slave. (s9 oct 29, s502 oct 11). ref #191

This breaks reconstructions: The api.Station object reads the most recent config, with 2 scintillators. This means api.Station.n_detectors == 2 and len(cluster.station.detectors) == 2

When reconstructing ESD events with 4 detectors, code like dx, dy, dz = self.station.detectors[id].get_coordinates() will obviously throw an IndexError.

As we cannot easily refurse/delete/ignore erroneous configs, we must fix api.Station (get rid of n_detectors???)

@153957
Copy link
Member

153957 commented Jul 21, 2022

The issue originates also from the publicdb;
https://github.com/HiSPARC/publicdb/blob/master/publicdb/inforecords/models.py#L252-L271

This is where the number_of_detectors is determined, which is used in the station API response, upon which SAPPHiRE bases its conclusion of the number of detectors.

Maybe that number_of_detectors should not be based on the presence of a slave config, but on data from the station or some other, more consistent/correct, source of information.

@davidfokkema
Copy link
Member

Also, aren't there examples of two-detector stations which were upgraded to be four-detector stations? Then the result is dependent on the date. I think the data should be the definitive source of truth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants