Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect GPS position of station #188

Open
kaspervd opened this issue Aug 21, 2018 · 4 comments
Open

Incorrect GPS position of station #188

kaspervd opened this issue Aug 21, 2018 · 4 comments

Comments

@kaspervd
Copy link

kaspervd commented Aug 21, 2018

The position you obtain if you do something like this:

from sapphire import HiSPARCStations
cluster = HiSPARCStations([509, 511])
s509 = cluster.stations[0]
lat, lon, _ = s509.get_lla_coordinates()
print(lat)
print(lon)

differs from the position you get using the API:
http://data.hisparc.nl/api/station/509/

The difference is several meters. This used to work correctly.. will investigate

@153957
Copy link
Member

153957 commented Aug 21, 2018

What is the result of your code, i.e. the output of the prints?
Have you tried different versions of SAPPHiRE?
I assume you are using the latest now?
I did make modifications to the transformations.geographic and clusters modules.
And if you fix it, please add additional tests for the geographic/cluster modules to prevent this from going wrong in the future.

@kaspervd
Copy link
Author

kaspervd commented Aug 21, 2018

I'm using the latest version, it is an undesired side effect of the shift to the center of mass frame in:
clusters.py

Without that line everything works correctly and thus also your modifications 👍

@kaspervd
Copy link
Author

I'll need some time to think about how to solve this :)

@153957
Copy link
Member

153957 commented Aug 21, 2018

That is not a recent change, so the actual cause is likely something else.
Perhaps you can git-bisect to find where exactly the result changed from good to bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants